Use "Datetime" ydb type for sa.DATETIME #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgvoleg
approved these changes
Aug 13, 2024
LuckySting
force-pushed
the
datetime-support
branch
from
3a7de78 to
90d8ad8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Now the "sa.DateTime", "sa.DATETIME" and "sa.Timestamp" are implemented by "Timestamp" ydb type, which is ok until you need to store data with "seconds" precision (timestamp has microseconds precision).
Proposal
Let's continue to use "Timestamp" for "sa.DateTime" and "sa.Timestamp", but for "sa.DATETIME" use "DateTime" to allow user to use "DateTime" columns.